Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the node_id to the Discussion Category payload #1335

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented Dec 1, 2021

I reported the fact that the field was missing to the GitHub team and
they were kind enough to add it so we can now take it into account.

The numeric id is not exposed at all in the GraphQL API and neither in the UI so if you want to reference an id, it's kinda problematic right now, you have to generate payloads and get the id from there.

With this addition, you will be able to reference the node_id which is present in the GraphQL API.

I reported the fact that the field was missing to the GitHub team and
they were kind enough to add it so we can now take it into account.
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1335 (e59b438) into main (08bff69) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1335   +/-   ##
=========================================
  Coverage     78.17%   78.18%           
  Complexity     2045     2045           
=========================================
  Files           200      200           
  Lines          6283     6284    +1     
  Branches        356      356           
=========================================
+ Hits           4912     4913    +1     
  Misses         1162     1162           
  Partials        209      209           
Impacted Files Coverage Δ
...ava/org/kohsuke/github/GHRepositoryDiscussion.java 93.10% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bff69...e59b438. Read the comment docs.

@bitwiseman bitwiseman merged commit 3e31bf6 into hub4j:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants